Skip to content

feat: add C implementation of stats/base/dists/arcsine/logpdf #3454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 11, 2024
Merged

feat: add C implementation of stats/base/dists/arcsine/logpdf #3454

merged 6 commits into from
Dec 11, 2024

Conversation

Vinit-Pandit
Copy link
Contributor

Resolves #3401

Description

What is the purpose of this pull request?

This pull request:

  • add c implementation of stats/base/dists/arcsine/logpdf

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 11, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 11, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/arcsine/logpdf $\color{green}293/293$
$\color{green}+100.00\%$ 		$\color{green}25/25$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}293/293$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

kgryte
kgryte requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @MeastroZI. Looks like you are missing changes to the package README.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 11, 2024
kgryte
kgryte reviewed Dec 11, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 11, 2024
View reviewed changes
@Vinit-Pandit Vinit-Pandit requested a review from kgryte December 11, 2024 09:43
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 11, 2024
@Planeshifter Planeshifter changed the title feat: add c implementation of stats/base/dists/arcsine/logpdf feat: add C implementation of stats/base/dists/arcsine/logpdf Dec 11, 2024
Planeshifter
Planeshifter approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @MeastroZI!

Fixed a few small things (in example printouts:F is used for the CDF, whereas f should be used for the PDF) but the PR looks good to me overall and should be ready to land! 🚀

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 11, 2024
@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Dec 11, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 11, 2024 •
edited by Planeshifter
Loading

PR Commit Message

feat: add C implementation of `stats/base/dists/arcsine/logpdf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3454
Closes: https://github.com/stdlib-js/stdlib/issues/3401

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 1d283b5 into stdlib-js:develop Dec 11, 2024
22 checks passed
@Vinit-Pandit Vinit-Pandit deleted the logpdf branch December 14, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@kgryte kgryte Awaiting requested review from kgryte

Assignees
No one assigned
Labels
Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/arcsine/logpdf
4 participants
@Vinit-Pandit @stdlib-bot @Planeshifter @kgryte